refactor: Handle common ReleaseMode.release logic in Dart#2017
Merged
Conversation
spydon
approved these changes
Jul 21, 2026
Sebastien-VZN
pushed a commit
to Sebastien-VZN/audioplayers
that referenced
this pull request
Jul 23, 2026
Commits marqués comme analyses et non portes: - 310304d ci: Upgrade CI Flutter version to v3.44.6 (bluefireteam#2014) — cosmétique CI - 244a4a0 ci: Support verbose debugging in tests (bluefireteam#2015) — cosmétique CI - 0b89829 test: Set timeouts for integration tests (bluefireteam#2016) — cosmétique tests - 6efd636 refactor: Handle common ReleaseMode.release logic in Dart (bluefireteam#2017) — redondant, deja gere nativement - fa6ec8e feat!: Add PlayingStateUpdate event (bluefireteam#1995) — over-engineering, 500 lignes pour rien - cd475c7 fix(windows): Crash Windows N Media Feature Pack (bluefireteam#2019) — try-catch global du fork couvre deja le cas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To more granularly handle releasing resources in
ReleaseMode.releaseit is desirable to handle it on the Dart side. This mitigates following problems:Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
It is a partly breaking change: The main package is not breaking anything, but the contract with the endorsed federated plugin packages has shifted. I personally would consider that as non breaking, as I doubt someone is relying on the interface where the
ReleaseMode.releaseis handled.Before:
After:
Related Issues